Skip to content

MGMT-20486: Use default source names #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielerez merged 1 commit into from
Apr 29, 2025
Merged

MGMT-20486: Use default source names #375

danielerez merged 1 commit into from
Apr 29, 2025

Conversation

@danielerez
Copy link
Contributor

@danielerez danielerez commented Apr 23, 2025 •
edited
Loading

Rename CatalogSource names generated by oc-mirror to the default naming.
E.g. 'redhat-operators' instead of 'cs-redhat-operator-index-v4-19'.
Default: false
[Optional]

appliance-config.yaml:

useDefaultSourceNames: false/true

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@danielerez
ApplianceConfig: support 'useDefaultSourceNames' flag
be3203c 
Rename CatalogSource names generated by oc-mirror to the default naming.
E.g. 'redhat-operators' instead of 'cs-redhat-operator-index-v4-19'.
Default: false
[Optional]

useDefaultSourceNames: false/true
@danielerez danielerez force-pushed the useDefaultSourceNames branch from df3295f to be3203c Compare April 23, 2025 08:57
@openshift-ci
Copy link

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@andfasano
Copy link
Contributor

andfasano commented Apr 24, 2025 •
edited
Loading

Currently blocked by openshift/assisted-service#7606

@danielerez danielerez changed the title Use default source names MGMT-20486: Use default source names Apr 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@danielerez: This pull request references MGMT-20486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Rename CatalogSource names generated by oc-mirror to the default naming.
E.g. 'redhat-operators' instead of 'cs-redhat-operator-index-v4-19'.
Default: false
[Optional]

appliance-config.yaml:

useDefaultSourceNames: false/true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2025
@pawanpinjarkar pawanpinjarkar mentioned this pull request Apr 25, 2025
Merged
@andfasano andfasano mentioned this pull request Apr 29, 2025
Merged
@danielerez danielerez marked this pull request as ready for review April 29, 2025 18:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
@openshift-ci openshift-ci bot requested review from avishayt and oourfali April 29, 2025 18:12
@andfasano
Copy link
Contributor

andfasano commented Apr 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2025

@danielerez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-compact-ipv4-static be3203c link true /test e2e-compact-ipv4-static

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielerez danielerez merged commit 49d632b into openshift:master Apr 29, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avishayt avishayt Awaiting requested review from avishayt

@oourfali oourfali Awaiting requested review from oourfali

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielerez @andfasano @openshift-ci-robot